Codicons are not rendered when filtering in quick pick

[RomanNikitenko]

• VSCode Version: 464ef8c
• OS Version: Fedora 31

I’m trying to use codicons for actions. It works well at displaying in command palette, but for some case an icon is not rendered.

Let’s say, Close Workspace action has $(chrome-close) Close Workspace label.
The icon is rendered properly for the item in command palette. Let’s try to type close to filter all close items. At this step the icon is not rendered.

I tested it using Monaco Playground:

Steps to Reproduce:

1. Replace label value by $(link) Open Link for OpenLinkAction
2. F1 -> find Open Link -> the icon should be rendered
3. F1 -> type link -> the icon is not rendered

Please see:

Does this issue occur when all extensions are disabled?: Yes/No

[miguelsolorio]

I'm not able to reproduce this on the mac:

@bpasero any ideas what could be happening here?

[miguelsolorio]

@RomanNikitenko can you link to a sample repo/extension where this is happening?

[bpasero]

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

[RomanNikitenko]

@misolori
In my case I have $(link) Open Link, (the icon contains link) and I'm typing link

Looks like you use label $(rocket) Hello World and you are typing hello.
So, the icon doesn't contain the word which you are typing (the icon contains rocket).
For your case, please try to type rocket.

[bpasero]

@RomanNikitenko to clarify, you only see this in the monaco editor but not VSCode?

[RomanNikitenko]

@bpasero
My second video (dark theme) was recorded using current master branch of VS Code.

In steps to reproduce section I mentioned that:

• I go to OpenLinkAction https://github.com/microsoft/vscode/blob/master/src/vs/editor/contrib/links/links.ts#L388
• and replace current link by $(link) Open Link
• type link (because $(link) contains link, you can not reproduce it if you type open for example)

Please, let me know if I'm doing something wrong.

[bpasero]

Indeed.

[bpasero]

I decided to strip codicons from commands for the command palette as I find this should have a consistent look and feel with our core commands that do not use icons too.

Any custom picker can still use codicons of course, but for accessibility reasons a command should have a good label and not rely on codicons anway.

[miguelsolorio]

Sounds good, I don't think this should be a problem since most commands start with the extension name (category).