Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal link provider links don't support git diff links #95114

Closed
Tyriar opened this issue Apr 13, 2020 · 0 comments · Fixed by #95608
Closed

Terminal link provider links don't support git diff links #95114

Tyriar opened this issue Apr 13, 2020 · 0 comments · Fixed by #95608
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links verified Verification succeeded
Milestone
April 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 13, 2020 •
edited
Loading

These 4 links from git log -p should work:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links labels Apr 13, 2020
@Tyriar Tyriar added this to the On Deck milestone Apr 13, 2020
@Tyriar Tyriar self-assigned this Apr 13, 2020
@Tyriar Tyriar mentioned this issue Apr 13, 2020
Closed
14 tasks
@Tyriar Tyriar modified the milestones: On Deck, April 2020 Apr 19, 2020
Tyriar added a commit that referenced this issue Apr 19, 2020
@Tyriar
Add git diff link support, fix multiple links on one line
80b8f58 
Fixes #95114
@Tyriar Tyriar mentioned this issue Apr 19, 2020
Merged
@Tyriar Tyriar added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues terminal-links verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Terminal link hover improvements microsoft/vscode
1 participant
@Tyriar