-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering whitespace influences bidi layout #99589
Comments
I think this is not a complaint about the emojis being rendered colourful, but with the bidi text layout, where the second emoji probably belongs to the second JSON string. |
Yes @alexdima , the output is ok, just in UI, I can't recognize which emoji should I select. |
Hello. |
Please help and check it out. |
Looks like a duplicate of #83365. The problem in both are the direction-neutral symbols, they both want direction-neutral to be forced LTR. Although this is only useful for structured text (i.e. json), and not for writing an RTL sentence with punctuation. |
Interesting, I think this might be caused by using render whitespace in selection, which influences the rendered line parts. |
To verify, configure {
"invoice_vip":[
["🖨️ چاپ فاکتور","🎨 تنظیمات"]
]
} Expected: the text doesn't "jump around" when selecting it. Actual: Kapture.2022-04-05.at.18.53.47.mp4To clarify, the fix will avoid rendering whitespace at all inside RTL tokens. This is not ideal, but better than the jumping the rendering of whitespace causes. |
This comment was marked as off-topic.
This comment was marked as off-topic.
…t (except for line leading and trailing whitespace)
Is this gonna be fixed soon? I still see the issue in 1.67 |
I have a json file in my project, emojies is ok in note pad ++ but in vs code is not good UI,
![jsonUI](https://user-images.githubusercontent.com/25050762/83992919-24106000-a967-11ea-8639-e98181863b9c.png)
photo:
json:
The text was updated successfully, but these errors were encountered: