Connor4312/terminal types contribution #100780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Jun 25, 2020
There was a problem hiding this comment.
Avoiding the string matching would definitely be nice, it was an existing problem though.
Just some minor comments, as it will be proposed I don't have problems with pushing this in once the comments are resolved. We should push to finalize it after it's been tested out though.
Tyriar
approved these changes
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #98054
Tried to mirror what I saw other parts of the workbench doing.
I tried to find a way to get back structured objects from the
SelectActionViewItemso that we didn't need to implement string matching, but found this difficult to do; the cleanest way would be deriving an interface from theISelectOptionItem, but the selection options aren't exposed back to theSelectActionViewItemat any point and the types in general always have the select only emitting a string.Seems to work, and should be fine as long as people don't contribute a terminal action that starts with
[0-9]: