Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable proposed API checks on top-level getters #112141

Merged
merged 1 commit into from
Dec 9, 2020
Merged

disable proposed API checks on top-level getters #112141

merged 1 commit into from
Dec 9, 2020

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Dec 9, 2020 •
edited
Loading

This PR disables proposed API checks on top level getters and thereby prevents #111913 from happening

@jrieken jrieken self-assigned this Dec 9, 2020
@jrieken jrieken added this to the November 2020 milestone Dec 9, 2020
@jrieken jrieken requested a review from alexr00 December 9, 2020 14:00
alexr00
alexr00 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Reproed in insiders and out of source, and tested fix.

@jrieken jrieken merged commit 6caba06 into release/1.52 Dec 9, 2020
@jrieken jrieken deleted the joh/fix/111913 branch December 9, 2020 14:29
@mwpenny mwpenny mentioned this pull request Dec 9, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@jrieken @alexr00