Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move terminal process to main #116185

Closed
wants to merge 11 commits into from
Closed

Move terminal process to main #116185

wants to merge 11 commits into from

Commits on Feb 8, 2021

  1. Move remoteterminalservice reg to contribution

    @Tyriar
    Tyriar committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    3021226 View commit details
    Browse the repository at this point in the history

  2. Create pty service main <-> renderer channel 

    Part of #74620
    @Tyriar
    Tyriar committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    ee4a8bd View commit details
    Browse the repository at this point in the history

  3. Rename pty service to local pty service 

    More descriptive as it's for local/electron terminal processes only
    @Tyriar
    Tyriar committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    281d228 View commit details
    Browse the repository at this point in the history

  4. Create createProcess ipc interface

    @Tyriar
    Tyriar committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    456841a View commit details
    Browse the repository at this point in the history

  5. Pass executableEnv to other side

    @Tyriar
    Tyriar committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1e298d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Get one way communication happening

    @Tyriar
    Tyriar committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    6132a76 View commit details
    Browse the repository at this point in the history

  2. Get 2 way communication working

    @Tyriar
    Tyriar committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    47adc86 View commit details
    Browse the repository at this point in the history

  3. Remove log

    @Tyriar
    Tyriar committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    4b5108a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into tyriar/74620_2

    @Tyriar
    Tyriar committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    3a3b42a View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into tyriar/74620_2

    @Tyriar
    Tyriar committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    f2f9d1b View commit details
    Browse the repository at this point in the history

  6. node-pty@0.11.0-beta1 

    This brings in microsoft/node-pty#415 which will finally fix the hang issue
on Windows with conpty. Performance on Windows should also improve a lot
because node-pty is now hosted outside of the cluttered renderer process.

Fixes #71966
    @Tyriar
    Tyriar committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    7b64e24 View commit details
    Browse the repository at this point in the history