Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force kill ptys on Windows on window exit #118437

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Don't force kill ptys on Windows on window exit #118437

merged 1 commit into from
Mar 8, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 8, 2021

Fixes #117956

@Tyriar Tyriar added this to the February 2021 Recovery 2 milestone Mar 8, 2021
@Tyriar Tyriar requested a review from meganrogge March 8, 2021 13:22
@Tyriar Tyriar self-assigned this Mar 8, 2021
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Mar 8, 2021
@Tyriar Tyriar merged commit c48a57b into release/1.54 Mar 8, 2021
@Tyriar Tyriar deleted the tyriar/1_54_117956 branch March 8, 2021 16:29
Tyriar added a commit that referenced this pull request Mar 8, 2021
@Tyriar
Include ms in shutdown constant comments
3df01b4 
Part of #118437
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
February 2021 Recovery 2
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @meganrogge