Workspace trust changes #119017
Merged
Workspace trust changes #119017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lszomoru
commented
Mar 15, 2021
lszomoru
commented
- Use separate promises for soft/modal notifications
- Add the capability to customise workspace trust dialog buttons
sbatten
reviewed
Mar 15, 2021
sbatten
reviewed
Mar 15, 2021
src/vs/workbench/contrib/workspace/browser/workspace.contribution.ts
Outdated
Show resolved
Hide resolved
sbatten
reviewed
Mar 15, 2021
sbatten
reviewed
Mar 15, 2021
sbatten
requested changes
Mar 15, 2021
lramos15
pushed a commit
that referenced
this pull request
Mar 16, 2021
* Add dialog button customisation and reject promise if cancelled * Use different promises to modal/soft requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.