Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drag and drop controller #123542

Merged
merged 3 commits into from
May 14, 2021
Merged

Add drag and drop controller #123542

merged 3 commits into from
May 14, 2021

Conversation

barbaravaldez
Copy link
Contributor

@barbaravaldez barbaravaldez commented May 11, 2021 •
edited
Loading

Rewrite current drag and drop API, so it accepts a drag and drop controller instead of just using a setParent method.
This PR fixes #32592

  • E2E wiring works
  • On next PR I'll modify the TreeDataProvider.onDidChangeTreeData event to fire arrays.

@alexr00 alexr00 self-assigned this May 11, 2021
alexr00
alexr00 requested changes May 11, 2021
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the changes!

src/vs/workbench/api/common/extHostTreeViews.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/browser/mainThreadTreeViews.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHost.protocol.ts Outdated Show resolved Hide resolved
src/vs/workbench/common/views.ts Outdated Show resolved Hide resolved
alexr00
alexr00 approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@alexr00 alexr00 merged commit 1a78b73 into microsoft:main May 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add drag and drop for contributed tree views
2 participants
@barbaravaldez @alexr00