Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm.js node target and serialize addon #129207

Merged
merged 16 commits into from
Aug 12, 2021
Merged

xterm.js node target and serialize addon #129207

merged 16 commits into from
Aug 12, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 23, 2021

Part of #116113
Fixes #127638

This builds on xtermjs/xterm.js#3212 to maintain an xterm.js instance no the pty host and use that to replay in the terminal.

The current situation can take ~300ms to replay a full cache of events. This will can be event worse when rendering is taken into account and depending on hardware. Extend that to say 3 busy terminals and that's a second slower reloading. This PR by contrast takes ~30ms to replay the viewport + 100 rows of scrollback.

image

The setup needed is to copy node_modules/xterm into node_modules/xterm-headless and then copy over the webpack build from xtermjs/xterm.js#3212 and adjust package.json and typings/xterm-headless.d.ts.

The serialize addon is currently inlined because the UMD build is not compatible with node due to the use of self.

Remaining work:

@Tyriar Tyriar added this to the July 2021 milestone Jul 23, 2021
@Tyriar Tyriar self-assigned this Jul 23, 2021
@Tyriar Tyriar changed the title Node target and serialize addon wip xterm.js node target and serialize addon wip Jul 23, 2021
@bpasero bpasero modified the milestones: July 2021, August 2021 Aug 9, 2021
@Tyriar Tyriar changed the title xterm.js node target and serialize addon wip xterm.js node target and serialize addon Aug 12, 2021
@Tyriar Tyriar merged commit 3bec131 into main Aug 12, 2021
@Tyriar Tyriar deleted the tyriar/116113 branch August 12, 2021 19:54
@Tyriar
Copy link
Member Author

Tyriar commented Aug 12, 2021

Moved remaining follow ups to #116113

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal renders during process reconnect (aka. replay)
2 participants