-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xterm.js node target and serialize addon #129207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
changed the title
Node target and serialize addon wip
xterm.js node target and serialize addon wip
Jul 23, 2021
Tyriar
changed the title
xterm.js node target and serialize addon wip
xterm.js node target and serialize addon
Aug 12, 2021
Moved remaining follow ups to #116113 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #116113
Fixes #127638
This builds on xtermjs/xterm.js#3212 to maintain an xterm.js instance no the pty host and use that to replay in the terminal.
The current situation can take ~300ms to replay a full cache of events. This will can be event worse when rendering is taken into account and depending on hardware. Extend that to say 3 busy terminals and that's a second slower reloading. This PR by contrast takes ~30ms to replay the viewport + 100 rows of scrollback.
The setup needed is to copy
node_modules/xterm
intonode_modules/xterm-headless
and then copy over the webpack build from xtermjs/xterm.js#3212 and adjustpackage.json
andtypings/xterm-headless.d.ts
.The serialize addon is currently inlined because the UMD build is not compatible with node due to the use of
self
.Remaining work: