-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single view cell state event listener #137486
Conversation
@@ -86,6 +86,19 @@ export class CellEditorOptions extends Disposable { | |||
this._value = this._computeEditorOptions(); | |||
} | |||
|
|||
prepareRender(): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be optional to implement these, seems that parts often don't need to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not everyone needs updateLayoutNow
either so we can probably use override
other than abstract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might still keep it though to ensure that when we add a new CellPart, we are aware that batching DOM read and writes are necessary.
} | ||
|
||
if (e.inputCollapsedChanged) { | ||
this.templateData.progressBar.updateForCellState(this.viewCell); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress bar can be a cell part right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roblourens yes, it would make good sense to make it a cell part.
Re #131808.
This PR implements
CellPart#updateState
and registers a single event listener for view cell state change.