Add support for arm64 for server builds #145053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
Mar 16, 2022
| @@ -12,7 +12,7 @@ const yarnrc = fs.readFileSync(yarnrcPath, 'utf8'); | |||
| const version = /^target\s+"([^"]+)"$/m.exec(yarnrc)![1]; | |||
|
|
|||
| const platform = process.platform; | |||
| const arch = platform === 'darwin' ? 'x64' : process.arch; | |||
| const arch = process.arch; | |||
deepak1556
reviewed
Mar 16, 2022
Comment on lines
+317
to
+335
| - publish: $(Agent.BuildDirectory)/vscode-server-darwin-arm64.zip | ||
| artifact: vscode_server_darwin_arm64_archive-unsigned | ||
| displayName: Publish arm64 server archive | ||
| condition: and(succeeded(), ne(variables['VSCODE_PUBLISH'], 'false'), eq(variables['VSCODE_ARCH'], 'arm64')) | ||
|
|
||
| - publish: $(Agent.BuildDirectory)/vscode-server-darwin-arm64-web.zip | ||
| artifact: vscode_web_darwin_arm64_archive-unsigned | ||
| displayName: Publish arm64 web server archive | ||
| condition: and(succeeded(), ne(variables['VSCODE_PUBLISH'], 'false'), eq(variables['VSCODE_ARCH'], 'arm64')) | ||
|
|
||
| - publish: $(Agent.BuildDirectory)/vscode-server-darwin.zip | ||
| artifact: vscode_server_darwin_$(VSCODE_ARCH)_archive-unsigned | ||
| displayName: Publish server archive | ||
| condition: and(succeeded(), eq(variables['VSCODE_ARCH'], 'x64'), ne(variables['VSCODE_PUBLISH'], 'false')) | ||
| artifact: vscode_server_darwin_x64_archive-unsigned | ||
| displayName: Publish x64 server archive | ||
| condition: and(succeeded(), ne(variables['VSCODE_PUBLISH'], 'false'), eq(variables['VSCODE_ARCH'], 'x64')) | ||
|
|
||
| - publish: $(Agent.BuildDirectory)/vscode-server-darwin-web.zip | ||
| artifact: vscode_web_darwin_$(VSCODE_ARCH)_archive-unsigned | ||
| displayName: Publish web server archive | ||
| condition: and(succeeded(), eq(variables['VSCODE_ARCH'], 'x64'), ne(variables['VSCODE_PUBLISH'], 'false')) | ||
| artifact: vscode_web_darwin_x64_archive-unsigned | ||
| displayName: Publish x64 web server archive | ||
| condition: and(succeeded(), ne(variables['VSCODE_PUBLISH'], 'false'), eq(variables['VSCODE_ARCH'], 'x64')) |
There was a problem hiding this comment.
@alexdima why duplicate these steps for each artifact over the previous version based on vscode_web_darwin_$(VSCODE_ARCH)_archive-unsigned and scode_server_darwin_$(VSCODE_ARCH)_archive-unsigned ?
There was a problem hiding this comment.
I tried to keep compatibility with the old names:
- the
x64versions are still calledvscode-server-darwin.zipandvscode-server-darwin-web.zip - the
arm64versions are calledvscode-server-darwin-arm64.zipandvscode-server-darwin-arm64-web.zip
I didn't know how to write a conditional inside the publish: field. If you know how to do it, please start a PR to remove the duplication.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode-remote-release#4069