Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git - use editor as commit message input #151491

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Git - use editor as commit message input #151491

merged 5 commits into from
Jun 8, 2022

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented Jun 8, 2022

Reapply changes from #95266 that had to be reverted. Additional changes compared to the PR:

  • GIT_EDITOR environment variable is only set if git.useEditorAsCommitInput is set
  • Adding the --ms-enable-electron-run-as-node argument when not running out of sources
  • We are only using .sh scripts similar to askpass

@lszomoru lszomoru requested a review from joaomoreno June 8, 2022 08:28
@lszomoru lszomoru self-assigned this Jun 8, 2022
@lszomoru lszomoru added the git GIT issues label Jun 8, 2022
@lszomoru lszomoru added this to the June 2022 milestone Jun 8, 2022
@lszomoru lszomoru mentioned this pull request Jun 8, 2022
Merged
@lszomoru lszomoru merged commit 6f5fc17 into main Jun 8, 2022
@lszomoru lszomoru deleted the lszomoru/git-commit-editor-2 branch June 8, 2022 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@lszomoru lszomoru

Labels
git GIT issues
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@lszomoru @joaomoreno