-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce --merge
to bring up merge editor (for #5770)
#155039
Conversation
@lramos15 @jrieken this is ready for a first look and should already work, despite not being the full solution yet, since the editor resolver is not yet working as we discussed, but I still think we could merge this to get feedback from users and work on the editor resolver independently. To try it out:
For Jo: mainly For Logan: mainly editor resolver changes: there is currently a hack that I explicitly set the PS: at first I used names such as //cc @hediet |
Can we pass the labels for the sides as command line argument?
|
src/vs/workbench/services/environment/browser/environmentService.ts
Outdated
Show resolved
Hide resolved
Yeah, maybe in another PR, will keep a note. Maybe there is also some cool ways in git config to let Git fill in a nice label via some script tricks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 , I will start on the resolver work
This PR is for #5770