Enable translations for extension code for the web #155355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
previously approved these changes
Jul 27, 2022
|
Actually this PR doesn't take advantage of vscode-nls 5.1.0 yet so this can just be merged in independently |
joyceerhl
pushed a commit
that referenced
this pull request
Aug 10, 2022
* Initial attempt * alex feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #
Depends on microsoft/vscode-nls#42
In short, the strategy is to load the message bundles ahead of time and then when the extension is getting loaded, return the pre-loaded strings.
The strategies are slightly different because the scanners are slightly different:
Please review this very harshly. This is code I am unfamiliar with and is owned by several folks.