add terminal quick fix API

[meganrogge]

fixes #162950

Deferring:

• resolve aliases before checking for terminal quick fixes #166501
• Moving away from the use of RegExpMatchArray

[Tyriar]

Feedback from API sync, plus some of my own comments I didn't bring up. Let's talk through them in our 1:1

• Regex matching on the renderer looks like something we're not willing to do as there are too many problems, even just capping the time could still result in UI lock ups/crashes. It's foreign code in the renderer
  • Should we send a slice of terminal output on the extension host to evaluate when a command finishes?
    • My big concern here is flooding the ext host connection, this has been a complaint in live share and general remote connections
  • Should we run the regex's in a worker off the renderer process via SAB if available?
• Should we split out command and args to make the initial matching simpler?
  • Is this flexible enough? What about mandatory command matcher and optional command line matcher?
• Should we make exitStatus required to further minimize the chance of misuse
• Remove TerminalCommandSelector being registered in the provider API? This is already provided in the contribution
• For the type property, we normally use classes in the extension host instead
• Concerns around TerminalQuickFixCommandAction.command being confused with a VS Code command were validated as the confusion happened in the call. I don't know of a good alternative. Perhaps spelling it out in the property as terminalCommand? We do this in the UI to avoid confusion between profiles and terminal profiles.
• Should we use the open command instead of the opener service? They're probably equivalent, make sure preview tabs work via the opener service.
• You can use hash fragments like #L... to indicate a file's line/col
• TerminalCommandMatchResult.outputMatch can be undefined and null
• With the command regex, this means I never get these when using my git aliases. But don't you already know I'm actually running a git process, because you change the terminal title to git?

[meganrogge]

• Is this flexible enough? What about mandatory command matcher and optional command line matcher?

I think we should require both, though it's entirely up to the extension in reality as they can just provide * as the regexp.

• Should we make exitStatus required to further minimize the chance of misuse

Yes - done

• Remove TerminalCommandSelector being registered in the provider API? This is already provided in the contribution

Yes - done

• TerminalCommandMatchResult.outputMatch can be undefined and null

Fixed

[Tyriar]

A point of interest dot is being added at the beginning now, caused by the UserAliases sequence?

[Tyriar]

It was caused by P UserAliases, we need to fix that when we re-introduce

[anthonykim1]

Is it possible for extension to use this terminal quick fix API?
I tried looking at https://code.visualstudio.com/api/references/vscode-api#CodeActionKind.QuickFix but only quick fix I see is for code action.