-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose fish integration configuration via XDG_DATA_DIRS
#168211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes microsoft#139400 `XDG_DATA_DIRS` is specified[1] as > a set of preference ordered base directories relative to which data files should be searched. the fish shell uses it[2] (among other things) to let *other tools* provide additional configuration files for the fish shell to load on startup. this change exposes the fish shell integration configuration script in a place matching what fish expects (in a `fish/vendor_conf.d` subdirectory) and appends the exposed directory to the value of `XDG_DATA_DIRS` if automatic shell integration is requested. if `XDG_DATA_DIRS` is unset it uses the specified default value `/usr/local/share:/usr/share` and appends the exposed xdg_data directory to that. [1]: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html [2]: https://fishshell.com/docs/current/language.html#configuration-files
@microsoft-github-policy-service agree |
Tyriar
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @mkhl, we'll need to make sure this works when bundled but it seems to work great out of main!
connor4312
approved these changes
Dec 16, 2022
Tyriar
added a commit
to microsoft/vscode-docs
that referenced
this pull request
Dec 16, 2022
gregvanl
pushed a commit
to microsoft/vscode-docs
that referenced
this pull request
Dec 16, 2022
* Update fish shell integration support See microsoft/vscode#168211 * Update shells to headers so they get anchors * Use bold rather than H4s Co-authored-by: Greg Van Liew <gregvanl@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #139400
XDG_DATA_DIRS
is specified1 asthe fish shell uses it2 (among other things)
to let other tools provide additional configuration files
for the fish shell to load on startup.
this change exposes the fish shell integration configuration script
in a place matching what fish expects
(in a
fish/vendor_conf.d
subdirectory)and appends the exposed directory to the value of
XDG_DATA_DIRS
if automatic shell integration is requested.
if
XDG_DATA_DIRS
is unset it uses the specified default value/usr/local/share:/usr/share
and appends the exposed xdg_data directory to that.