Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Volar for the built-in HTML Extension #171547

Open
wants to merge 89 commits into
base: main
Choose a base branch
from

Conversation

johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Jan 17, 2023

This PR tries to implement html-language-features with Volar.js, which is the framework used by Vue - Official, MDX, Astro behind the scenes. Compared with the original implementation, supporting embedded documents should be much simpler.

Refactors

  • Embedded Language Support
    • HTML
    • CSS
    • TS
      • Built-in jquery types
  • Tests
    • completions.test.ts
    • documentContext.test.ts
    • embedded.test.ts
    • folding.test.ts
    • formatting.test.ts
    • rename.test.ts
    • selectionRanges.test.ts
    • semanticTokens.test.ts
    • words.test.ts (No longer needed)
  • Language Participants
  • Custom Data from External Extensions
  • l10n
  • Browser Support

Features / Bug Fixes

@johnsoncodehk johnsoncodehk changed the title feat: migrated to @volar/language-server Adopt embedded language framework for HTML extension Jan 17, 2023
@aeschli
Copy link
Contributor

aeschli commented Jan 18, 2023

That's really cool, well architectured.
It would be great if we could switch to such a setup and profit from your work. The main challenge is of course that we would rely on a code base that is all owned by volar. I'll bring it up for discussion with the team here and we see what can be done.

@johnsoncodehk johnsoncodehk mentioned this pull request Feb 8, 2024
42 tasks
@johnsoncodehk johnsoncodehk changed the title Adopt embedded language framework for HTML extension Integrate Volar for HTML Extension Feb 9, 2024
@johnsoncodehk johnsoncodehk changed the title Integrate Volar for HTML Extension Integrate Volar for the built-in HTML Extension Feb 9, 2024
@laundmo
Copy link

laundmo commented Oct 25, 2024

This would be great to have - was there any decision by the team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment