-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Volar for the built-in HTML Extension #171547
Open
johnsoncodehk
wants to merge
89
commits into
microsoft:main
Choose a base branch
from
johnsoncodehk:volar-html
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsoncodehk
changed the title
feat: migrated to @volar/language-server
Adopt embedded language framework for HTML extension
Jan 17, 2023
That's really cool, well architectured. |
42 tasks
johnsoncodehk
force-pushed
the
volar-html
branch
from
February 9, 2024 00:34
38a39db
to
4a8997a
Compare
johnsoncodehk
changed the title
Adopt embedded language framework for HTML extension
Integrate Volar for HTML Extension
Feb 9, 2024
johnsoncodehk
changed the title
Integrate Volar for HTML Extension
Integrate Volar for the built-in HTML Extension
Feb 9, 2024
This would be great to have - was there any decision by the team? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to implement
html-language-features
with Volar.js, which is the framework used by Vue - Official, MDX, Astro behind the scenes. Compared with the original implementation, supporting embedded documents should be much simpler.Refactors
words.test.ts(No longer needed)Features / Bug Fixes
@ts-ignore
,@ts-expecte-error
...)