Consistently expand or collapse all comments on a line #176967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR microsoft#176641 cleaned up the redundant, explicit calls to these methods in `toggleExpand()` as they already happen in the `onDidChangeCollapsibleState` listener if `_expanded` doesn't match the new collapsible state. `hide()` was also adjusted there to call `deleteCommentThread()` as needed.
joyceerhl
approved these changes
Mar 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77155.
I verified this locally with a test extension that populates some comments, but have not covered the scenario of collapsing a newly created comment thread, where collapsing apparently is meant to delete the thread again in
hide():vscode/src/vs/workbench/contrib/comments/browser/commentThreadZoneWidget.ts
Line 469 in 711cd94