chore: push eol notifications for windows 8 and 8.1 #177668
Conversation
deepak1556
force-pushed
the
robo/eol_win_8
branch
from
4a7c010 to
d40a885
Compare
| const eolReleases = new Map<string, Map<string, string>>([ | ||
| ['6', new Map<string, string>([ | ||
| ['1', 'Windows 7 / Windows Server 2008 R2'], | ||
| ['2', 'Windows 8 / Windows Server 2012'], | ||
| ['3', 'Windows 8.1 / Windows Server 2012 R2'], | ||
| ])], | ||
| ]); |
There was a problem hiding this comment.
Should this be extracted outside of this method?
There was a problem hiding this comment.
Version mappings are different between Windows and MacOS, so keeping them separate is better for simplicity.
| this.bannerService.show({ | ||
| id: 'windowseol.banner', | ||
| message, | ||
| ariaLabel: localize('windowseolarialabel', "{0}. Use navigation keys to access banner actions.", message), | ||
| actions, | ||
| icon: Codicon.warning | ||
| }); |
There was a problem hiding this comment.
@deepak1556 Please add a neverShowAgain option to the windowseol bannerService in line 721. It's annoying to have to close it every time I start Insiders. I know I'm running an unsupported Windows version and I don't really need a reminder every time. I want to be able to dismiss it forever. Is that possible to do?
There was a problem hiding this comment.
@deepak1556 I second @lorand-horvath request, we do not need a nag every time a project is opened!
|
Sorry that my review triggered an auto merge! |
Refs #177676
In preparation for Electron >=23, branch-off from #175818