-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terminal tab hover action for env changes #177730
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...ib/terminalContrib/environmentChanges/browser/terminal.environmentChanges.contribution.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import { Schemas } from 'vs/base/common/network'; | ||
| import { localize } from 'vs/nls'; | ||
| import { Action2, registerAction2 } from 'vs/platform/actions/common/actions'; | ||
| import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; | ||
| import { EnvironmentVariableMutatorType, IMergedEnvironmentVariableCollection } from 'vs/platform/terminal/common/environmentVariable'; | ||
| import { ITerminalService } from 'vs/workbench/contrib/terminal/browser/terminal'; | ||
| import { TerminalCommandId } from 'vs/workbench/contrib/terminal/common/terminal'; | ||
| import { TerminalContextKeys } from 'vs/workbench/contrib/terminal/common/terminalContextKey'; | ||
| import { terminalStrings } from 'vs/workbench/contrib/terminal/common/terminalStrings'; | ||
| import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; | ||
| import { URI } from 'vs/base/common/uri'; | ||
|
|
||
| const category = terminalStrings.actionCategory; | ||
|
|
||
| // TODO: The rest of the terminal environment changes feature should move here https://github.com/microsoft/vscode/issues/177241 | ||
|
|
||
| registerAction2(class extends Action2 { | ||
| constructor() { | ||
| super({ | ||
| id: TerminalCommandId.ShowEnvironmentContributions, | ||
| title: { value: localize('workbench.action.terminal.showEnvironmentContributions', "Show Environment Contributions"), original: 'Show Environment Contributions' }, | ||
| category, | ||
| f1: true, | ||
| precondition: TerminalContextKeys.processSupported | ||
| }); | ||
| } | ||
| async run(accessor: ServicesAccessor) { | ||
| const collection = accessor.get(ITerminalService).activeInstance?.extEnvironmentVariableCollection; | ||
| if (collection) { | ||
| const editorService = accessor.get(IEditorService); | ||
| await editorService.openEditor({ | ||
| resource: URI.from({ | ||
| scheme: Schemas.untitled | ||
| }), | ||
| contents: describeEnvironmentChanges(collection), | ||
| languageId: 'markdown' | ||
| }); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
|
|
||
| function describeEnvironmentChanges(collection: IMergedEnvironmentVariableCollection): string { | ||
| let content = `# ${localize('envChanges', 'Terminal Environment Changes')}`; | ||
| for (const [ext, coll] of collection.collections) { | ||
| content += `\n\n## ${localize('extension', 'Extension: {0}', ext)}`; | ||
| content += '\n'; | ||
| for (const [variable, mutator] of coll.map.entries()) { | ||
| content += `\n- \`${mutatorTypeLabel(mutator.type, mutator.value, variable)}\``; | ||
| } | ||
| } | ||
| return content; | ||
| } | ||
|
|
||
| function mutatorTypeLabel(type: EnvironmentVariableMutatorType, value: string, variable: string): string { | ||
| switch (type) { | ||
| case EnvironmentVariableMutatorType.Prepend: return `${variable}=${value}\${env:${variable}}`; | ||
| case EnvironmentVariableMutatorType.Append: return `${variable}=\${env:${variable}}${value}`; | ||
| default: return `${variable}=${value}`; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the readonly
inMemoryscheme make more sense in this use case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like this is what I want, but I tried and get this. Am I doing something wrong?
I wanted to avoid creating a file service provider for a scheme