Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re #167719. Avoid heap operations when dealing with large files. #193309

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Re #167719. Avoid heap operations when dealing with large files. #193309

merged 1 commit into from
Sep 18, 2023

Conversation

rebornix
Copy link
Member

Add checks for if the text buffer is too large and we should avoid operations like getValue, getLinesContent to prevent OOM crashes.

@rebornix rebornix self-assigned this Sep 17, 2023
@rebornix rebornix requested a review from alexdima September 17, 2023 19:10
@vscodenpa vscodenpa added this to the September 2023 milestone Sep 17, 2023
@rebornix rebornix mentioned this pull request Sep 17, 2023
Open
3 tasks
alexdima
alexdima approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rebornix rebornix merged commit 90854de into main Sep 18, 2023
@rebornix rebornix deleted the rebornix/key-emu branch September 18, 2023 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@rebornix @alexdima @vscodenpa