watcher - emit URI
instead of string
for faster fsPath
compute (for #194341)
#194774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only do we now emit
Uri
from the watcher (or more specifically:UriComponents
), but we will also have.fsPath
computed in the watcher process. This is because each event goes through the coalescing process:vscode/src/vs/platform/files/common/watcher.ts
Lines 318 to 324 in 7ca0b35
fyi @jrieken