watcher - correlate events to their requesting source #194776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
changed the title
DonJayamanne
approved these changes
Oct 10, 2023
|
fyi @lszomoru, this makes it possible for an extension such as Git to fully own a recursive file watcher with custom exclude rules even inside the workspace. I remember we had talked about it and was not sure if you still have a usecase for it. |
This was referenced Oct 10, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
* watcher - emit `URI` instead of `string` for faster `fsPath` compute (for microsoft#194341) * wip * more * adopt * some cleanup * cleanup * cleanup * cleanup * cleanup * cleanup * cleanup * implement correlation * cleanup * add correlation * undo, leave for later * tests * tests * tests * tests * tests * log cId * simpler correlation id * 💄 * tests * runs * skip normalization * fix tests * tests * fix tests * add `createWatcher` API * partition events in ext host * allow custom excludes * remove disk file change * 💄 * 💄 * 💄 * wire in * wire in
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.