-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute to json language server with a custom language. #198583
Conversation
@aeschli should I remove the optional allow |
It would be nice if we can keep it simple an only support extending That said, yes, it's already possible to allow comments via scheme, but again, we consider this a VS Code internal thing. |
I don't want to hard code the We need to give the server a list of language ids. It e.g. needs it to dynamically register the formatters. I think that's an oversight in the HTML code. |
Found it
Yeah.. html does hardcode
Tho I still have no idea how to pass the
I'm not sure I understand, you don't want to support extending
I've double checked that works, so I guess I can safely remove the hardcoded |
extensions/json-language-features/client/src/languageParticipants.ts
Outdated
Show resolved
Hide resolved
extensions/json-language-features/client/src/languageParticipants.ts
Outdated
Show resolved
Hide resolved
Thanks, now all looks good. I'll merge it for February. |
Allow extensions to enable the builtin
json-language-features extension
on their own personal jsonlanguageId
PR fixes #198025
@aeschli
following the PR of #146731 as reference
Extensions wanting to enable the json language server
only need to add 3 things to their
package.json
file:EDIT: A blank
"main": ""
is required for"extensionDependencies"
to be able to start thejson-language-features
extensionI am unsure how to go about sending a
allowComments
setting to the language servermaybeEDIT: it already isallowComments
could be part of schema?vscode/extensions/json-language-features/server/src/jsonServer.ts
Line 363 in 6f7e102
currently I've just hard coded theEDIT: removedsnippets
language in jsonServer.ts#L363and everything relating to
comments
in languageParticipants.ts#L17-L21 is currently unused