Fix auto indent when pasting lines that begin with a comment #201421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The special handling for comments was originally added in 886f472 to fix microsoft#29753, but it had the side effect of preventing a desired auto indent in the majority of cases when pasting lines beginning with a comment (basically, all cases except multiline docblock style comments at the leftmost indentation level). That case has since been solved in a different way by e77b196, so removing this special handling gives us the best of both worlds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201420
The special handling for comments was originally added in 886f472 to fix #29753, but it had the side effect of causing #201420 -- preventing a desired auto indent in the majority of cases when pasting lines beginning with a comment (basically, all cases except multiline docblock style comments at the leftmost indentation level). That case has since been solved in a different way by e77b196, so removing this special handling gives us the best of both worlds.