Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip server requirements check based on file presence #203731

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: skip server requirements check based on file presence #203731

merged 2 commits into from
Jan 31, 2024

Conversation

deepak1556
Copy link
Collaborator

Fixes #203728

@deepak1556 deepak1556 added the candidate Issue identified as probable candidate for fixing in the next release label Jan 29, 2024
@deepak1556 deepak1556 added this to the December / January 2024 milestone Jan 29, 2024
@deepak1556 deepak1556 self-assigned this Jan 29, 2024
@deepak1556
Copy link
Collaborator Author

Build for testing https://monacotools.visualstudio.com/Monaco/_build/results?buildId=253993&view=results

@aiday-mar
Copy link
Contributor

Hey Deepak, do you think this will be merged into release before EOD Redmond today? Assuming it is not, then I suppose the corresponding issue is not a candidate.

@deepak1556 deepak1556 marked this pull request as ready for review January 31, 2024 02:36
@deepak1556 deepak1556 enabled auto-merge (squash) January 31, 2024 02:36
@deepak1556 deepak1556 merged commit 0504748 into release/1.86 Jan 31, 2024
6 checks passed
@deepak1556 deepak1556 deleted the robo/skip_requirements_check_1_86 branch January 31, 2024 02:49
@deepak1556
Copy link
Collaborator Author

@aiday-mar it is a candidate, pinged offline with details.

@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@deepak1556 deepak1556

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @aiday-mar @rzhao271