Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proposed TerminalState.isShellIntegrationActivated #207197

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 8, 2024

This is not protected to only proposed extensions, not clear how to do it easily for a property.

Part of #205058

This is not protected to only proposed extensions, not clear how
to do it easily for a property.

Part of #205058
@Tyriar Tyriar added this to the March 2024 milestone Mar 8, 2024
@Tyriar Tyriar self-assigned this Mar 8, 2024
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to be failing

@Tyriar Tyriar enabled auto-merge March 11, 2024 12:03
@Tyriar Tyriar requested a review from karrtikr March 11, 2024 12:04
@meganrogge
Copy link
Contributor

Looks like you just need to update the test

@Tyriar Tyriar merged commit af3992d into main Mar 12, 2024
6 checks passed
@Tyriar Tyriar deleted the tyriar/205058 branch March 12, 2024 15:10
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants