add option to dock terminal at top

[mxts]

for #201452

[mxts]

@microsoft-github-policy-service agree company="Avexsoft"

[mxts]

@abhijit-chikane would you be so kind to help with community PR approvals? thanks!

[mxts]

@sbatten would you be able to help? Thank you.

[mxts]

@sbatten can help? thanks

[mxts]

@benibenj @sbatten @meganrogge possible to give some feedback on this please?

I would have opt for an extension if it was possible to move the terminal but VSCode has a restriction here https://code.visualstudio.com/api/extension-capabilities/overview#no-dom-access

I use a 27" monitor, without this feature, I constantly have to look up and down from the top section to the lowest line on the screen and really causes strain on the neck. Thanks.

[benibenj]

Have you already tried moving the terminal into the editor? This would allow you to place the terminal at the top.

[mxts]

@benibenj how do you do that? I tried dragging with the mouse and it would not work.

Shows a no entry sign

Also, would it activate with ctrl+~?

[mxts]

@ agree

[mxts]

@ agree company="Avexsoft"

[benibenj]

Right click on one of the terminal instances.

If you only have one terminal instance you can just left click on it in the panel bar.

There also is a command Terminal: Create New Terminal in Editor Area

[mxts]

Thanks, managed to move it, but ctrl+~ does not activate it, it opens a new one at the bottom😅

I mean, it isn't just the terminal, it's everything in the panel, i.e. problems, output etc, terminal is just the most frequently used.

[mxts]

@benibenj i gave your suggestions a shot, but it created other problems, is a merge possible? Thank you.

[mxts]

@benibenj what do you think? thanks

[benibenj]

I'll have a look at this in June and discuss with the team if this is something we want to support

[benibenj]

There is still a couple things missing:

• Panel Border bottom when it is at the top:

=> in panelpart.css: add border bottom width 1 when panel at top

=> in panelPart.ts: update styles should set container.style.borderBottomColor and layout should remove 1px of the height when at top

• Show correct maximize icon (should point to bottom when panel at top):

• When changing the alignment of the panel, the panel is drawn at the bottom
  

• When reloading the panel is rendered at the bottom

I have some smaller changes I would like to do, but somehow it does not allow me to push commits to this PR so I might do them after we merge this PR.

• Run Find All References on Position.BOTTOM, there seems to be some checks regarding bottom position when maximizing which is not considering the top position. Maybe they should?

[benibenj]

@mxts would you be open to grant me permissions to push commits to this PR? This would allow me to help you out with some of the required changes. There should be a button called Allow edits from maintainers

[mxts]

Certainly! But how do I do that? I'm trying to look for allow maintainers to edit

[benibenj]

You should be able to see some action/checkbox below reviewers on this page
Docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

[mxts]

I just don't have it, an alternative is that i invited to avexsoft.. maybe then u can commit to it.

[benibenj]

I guess there is not mention of it further down in the sidebar? I just found online that it would be bellow the list of participants

[mxts]

Nothing

[benibenj]

That's weird. I've never seen this before. It's telling me I do not have permission to push to the PR. Possibly because the branch belongs to an organisation. I might have to create a fork to be able to make some changes

[mxts]

Ok, let me know if there is any settings I can change.

[benibenj]

Let's try this: I created a PR with my changes against your fork. If you review and approve it, it will be part of this PR.
Please also give it a try and make sure it works as expected

avexsoft#1

[mxts]

I have merged the changes, but have some trouble compiling VSCode... let me try and sort it out.

[benibenj]

I approved it. This will allow the pipeline to run. Let me know after you tested and are happy with the behaviour. If all tests pass and you agree with my changes, we can merge the PR :)

[Tyriar]

terminal/ looks good 👏

[mxts]

yes @benibenj please merge thanks!