Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IconSelectBox to change terminal icon, remove dupes #209118

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 29, 2024

Fixes #199964

Screenshot 2024-03-29 at 9 14 46 AM

meganrogge
meganrogge previously approved these changes Mar 29, 2024
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, though some tests are failing

@Tyriar
Copy link
Member Author

Tyriar commented Mar 29, 2024

@meganrogge just going to remove those tests instead of getting the icon box working in the smoke tests

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more tests

@amunger amunger requested a review from meganrogge April 1, 2024 15:05
@Tyriar Tyriar merged commit bf9f038 into main Apr 1, 2024
6 checks passed
@Tyriar Tyriar deleted the tyriar/199964 branch April 1, 2024 15:32
@AnrDaemon
Copy link

So, ugh, what about icons for profiles? I want each profile marked with appropriately recognizable language icon. But the only those I've found were Java and Python.

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the new icon picker generally usable for other components and adopt in terminal
4 participants