-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IconSelectBox to change terminal icon, remove dupes #209118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, though some tests are failing
@meganrogge just going to remove those tests instead of getting the icon box working in the smoke tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few more tests
So, ugh, what about icons for profiles? I want each profile marked with appropriately recognizable language icon. But the only those I've found were Java and Python. |
Fixes #199964