get request to show up in chat view #209147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Mar 29, 2024
src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts
Outdated
Show resolved
Hide resolved
…ChatController.ts
meganrogge
commented
Mar 29, 2024
src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatController.ts
Outdated
Show resolved
Hide resolved
…ChatController.ts
Tyriar
approved these changes
Mar 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took awhile 😓 . the issue was passing in the response as
IParsedChatRequestmeant it was getting parsed using theparts: []so resulted in the empty string. Instead, we now just pass in the string query.The other changes are just simplifying the code because we cache the current request, so don't need to go looking for it in a convoluted way.
fixes https://github.com/microsoft/vscode-copilot/issues/4725