Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt ensureNoDisposablesLeaked in code action model tests #209279

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

adopt ensureNoDisposablesLeaked in code action model tests #209279

wants to merge 11 commits into from
+24 −20

Commits on Apr 1, 2024

  1. adopt ensureNoDisposables

    @justschen
    justschen committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    d8f0dee View commit details
    Browse the repository at this point in the history

  2. fix the leaky leak

    @justschen
    justschen committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a2f7e04 View commit details
    Browse the repository at this point in the history

  3. passing tests, but TS error

    @justschen
    justschen committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    ee71421 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. better fix, put disposal behind try/catch

    @justschen
    justschen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2394fcc View commit details
    Browse the repository at this point in the history

  2. better fix, put disposal behind try/catch

    @justschen
    justschen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4d25e85 View commit details
    Browse the repository at this point in the history

  3. switch to using disposable store

    @justschen
    justschen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2907961 View commit details
    Browse the repository at this point in the history

  4. add timeout for disposable

    @justschen
    justschen committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f005f2e View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. remove extra disposables

    @justschen
    justschen committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a18a742 View commit details
    Browse the repository at this point in the history

  2. another extra disposable store removal

    @justschen
    justschen committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0dcb64a View commit details
    Browse the repository at this point in the history

  3. Adds back using disposable store, no more leaking

    @justschen
    justschen committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a5dc84c View commit details
    Browse the repository at this point in the history

  4. clear and dispose?

    @justschen
    justschen committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    88f4711 View commit details
    Browse the repository at this point in the history