Update code.cmd #209315
Closed
Update code.cmd #209315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue where the cmd window remains when executing the code command under cmd to open vscode. The issue ： microsoft#70139
longtsing
commented
Apr 2, 2024
|
@DonJayamanne May I have the Honor to contribute for the vscode?Please. |
|
@longtsing The issue has been closed, please create a new issue so we know what you are trying to address. |
the new issue is these: |
|
@DonJayamanne hello? |
|
@longtsing I would suggest you first wait for the issue to get triaged by @roblourens |
yunxu1019
reviewed
May 1, 2024
There was a problem hiding this comment.
是的，不过加 /B 参数是为了保持兼容性，windows 10下可能加不加都一样，但是其他的版本的 windows 加个 /b 应该好一些。
|
See #66750 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue where the cmd window remains when executing the code command under cmd to open vscode.
The issue ：
#210876
#70139
The reason for the bug is that when cmd opens vscode in the foreground, it will get stuck in the event loop of electron.
So the cmd window can only exit automatically after vscode exits.
The solution is to open a new process and open vsocode in the background.