Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syncing profiles #209336

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix syncing profiles #209336

merged 1 commit into from
Apr 2, 2024

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Apr 2, 2024

fix #208710

  • Change the order of syncing removed and added profiles. First remove the profiles and then add the new profiles.

@sandy081 sandy081 self-assigned this Apr 2, 2024
@sandy081 sandy081 enabled auto-merge (squash) April 2, 2024 10:09
@deepak1556 deepak1556 added the candidate Issue identified as probable candidate for fixing in the next release label Apr 2, 2024
@deepak1556 deepak1556 added this to the March 2024 milestone Apr 2, 2024
@sandy081 sandy081 merged commit ae59067 into release/1.88 Apr 2, 2024
7 checks passed
@sandy081 sandy081 deleted the sandy081/previous-firefly branch April 2, 2024 11:36
sandy081 added a commit that referenced this pull request Apr 2, 2024
sandy081 added a commit that referenced this pull request Apr 2, 2024
* fix syncing profiles (#209336)

fix #208710

* bailout if profile with same name exists already

* make it sync
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants