Logging navigible container events for debug #209357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
requested changes
Apr 2, 2024
There was a problem hiding this comment.
I'm seeing unknown configuration value for that setting @hsfzxjy
I also suggest that we should only log when that setting is enabled.
|
I was not quite familiar with how to register a config item. Could you shed some light on it? |
Fair enough. Would change it. |
|
@hsfzxjy your setting is actually working as expected. we don't want to register the configuration. Once you've made the change to only log (debug level) when that setting is enabled, this is good to go! thanks |
meganrogge
approved these changes
Apr 2, 2024
lramos15
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the tracing function mentioned in #200259