Fix output vsbuffer transfer via workspace edit. #209358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing Workspace Edit with notebooks, I found that when insert cells with outputs, outputs are always dropped. Turned out to be that we are not sending
VSBuffer
properly.Notebook's execute handler will wrap the output updates with
SerializableObjectWithBuffers
to ensure that the buffers in outputs are serialized/deserialized correctly.vscode/src/vs/workbench/api/common/extHostNotebookKernels.ts
Line 623 in 39df90b
Since we have notebook edits (which can contain output buffers) in
WorkspaceEdit
, we might want to do the same withMainThreadBulkEditsShape#$tryApplyWorkspaceEdit
cc @jrieken @mjbvz