Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output vsbuffer transfer via workspace edit. #209358

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Apr 2, 2024

While playing Workspace Edit with notebooks, I found that when insert cells with outputs, outputs are always dropped. Turned out to be that we are not sending VSBuffer properly.

Notebook's execute handler will wrap the output updates with SerializableObjectWithBuffers to ensure that the buffers in outputs are serialized/deserialized correctly.

return this._proxy.$updateExecution(this._handle, new SerializableObjectWithBuffers(updates));

Since we have notebook edits (which can contain output buffers) in WorkspaceEdit, we might want to do the same with MainThreadBulkEditsShape#$tryApplyWorkspaceEdit

cc @jrieken @mjbvz

@rebornix rebornix self-assigned this Apr 2, 2024
@rebornix rebornix requested review from jrieken and mjbvz April 2, 2024 18:07
@rebornix rebornix marked this pull request as ready for review April 2, 2024 18:07
@rebornix rebornix merged commit ba3e5f9 into main Apr 3, 2024
6 checks passed
@rebornix rebornix deleted the rebornix/clever-lobster branch April 3, 2024 15:49
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants