Feat: Bolder Typeface + Configurable Letter Spacing for Minimap's Section Header Labels ✨ #209990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
between the characters for better readability.
Spacing of the Minimap
pouyakary
changed the title
pouyakary
changed the title
pouyakary
changed the title
|
I have noticed that overflow is not addressed correctly: 
I have changed the PR to a draft so that I can fix it. |
|
Overflow is fixed: 
|
pouyakary
force-pushed
the
pouya/better-minimap-labels
branch
from
d44d63d to
ac91d42
Compare
|
Sorry I closed it by mistake trying to post a comment. One thing about the bold typeface is that if you notice it, in some screenshots it is bold, and in some (like my machine) it was not. So I guess putting the weight ensures we're all on the same thing. However, I guess in the future it could be very nice to have a custom font for the minimal headers in the settings. Maybe each person sees better with a different font. |
pouyakary
changed the title
|
@alexdima can you please check this out? |
andreamah
approved these changes
May 27, 2024
|
@alexdima thank you a lots! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #209989 and brings a bolder minimal Section Header Label with letter spacing for the section header labels configurable by user: