Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump electron@29.4.0 #213050

Merged
merged 7 commits into from
May 20, 2024
Merged

chore: bump electron@29.4.0 #213050

merged 7 commits into from
May 20, 2024

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented May 20, 2024 •
edited
Loading

Fixes #210842
Fixes #212678
Fixes #146422

@deepak1556 deepak1556 added this to the May 2024 milestone May 20, 2024
@deepak1556 deepak1556 self-assigned this May 20, 2024
@Jerri1986 Jerri1986 mentioned this pull request May 20, 2024
Closed
@deepak1556 deepak1556 marked this pull request as ready for review May 20, 2024 12:37
@deepak1556 deepak1556 enabled auto-merge (squash) May 20, 2024 12:37
@deepak1556 deepak1556 merged commit 28ebd91 into main May 20, 2024
6 checks passed
@deepak1556 deepak1556 deleted the robo/update_electron branch May 20, 2024 15:31
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this pull request May 22, 2024
@deepak1556 @mustard-mh
chore: bump electron@29.4.0 (microsoft#213050)
7ff1d29 
* chore: bump electron@29.4.0

* chore: remove io_uring workaround

* chore: bump distro

* chore: update dialog result for canceled save dialogs

Refs electron/electron@fe01ed7

* chore: add back io_uring workaround for remote oss tests

* chore: update nodejs v20.9.0 build

* chore: add back io_uring workaround for remote tests
@crhy
Copy link

crhy commented May 30, 2024

I'm having the same issue. Linux Mint 21.3 Mate with Compiz. Most frequently annoying with Chromium and Kdenlive.

How do I force an update to the fixed branch?

@deepak1556
Copy link
Collaborator Author

@crhy please clarify the issue you are facing. The changes from this PR will be available with 1.90.0 release next week.

@WilliamKyle
Copy link

what is the ms_build_id in .yarnrc mean?
If I want to upgrade electron to 30.0.9, what should ms_build_id be?

electron 30.0.9 base on Chromium 124.0.6367.0 and fix #167556

@crhy
Copy link

crhy commented Jun 5, 2024

@crhy please clarify the issue you are facing. The changes from this PR will be available with 1.90.0 release next week.

I'm having that issue in the latest Mint Mate version where you click Upload in Chromium for example, and the file dialog is missing until you minimize the main window. Then it appears.

@deepak1556
Copy link
Collaborator Author

Issue should be addressed in latest stable, please try it out.

@WilliamKyle those are our internal builds that contain additional patches on top of OSS Electron. We will explore Electron 30 update in the upcoming milestones, please follow #214394 for updates

@microsoft microsoft locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kieferrm kieferrm kieferrm approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
May 2024
4 participants
@deepak1556 @crhy @WilliamKyle @kieferrm