feat: allow extensions to attach chat context #213172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
approved these changes
May 21, 2024
roblourens
reviewed
May 21, 2024
| * @param value - The value of the chat context. | ||
| * @param location - The location of the chat context. | ||
| */ | ||
| export function attachContext(name: string, value: string | Uri | Location | unknown, location: ChatLocation.Panel): void; |
There was a problem hiding this comment.
I think this should have an ID actually
There was a problem hiding this comment.
Should VS Code actually be doing this for stuff likes files and selections? #file and the new attachment picker are still totally driven from core right?
There was a problem hiding this comment.
Yeah they're still totally driven by core, I'd like to also have #file extension land though because it's effectively a dynamic variable resolver but is special cased in a bunch of places right now.
andremmsilva
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
* feat: allow extensions to attach chat context * fix: allow attaching different ranges from same file * fix: restore accepting files from picker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.