Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking comment thread when CellComment is reused. #214589

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Fix leaking comment thread when CellComment is reused. #214589

merged 5 commits into from
Jun 24, 2024

Commits on Jun 7, 2024

  1. Fix leaking comment thread when CellComment is reused. 

    Fixes microsoft#214585.
    @rehmsen
    rehmsen committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    8c82ca1 View commit details
    Browse the repository at this point in the history

  2. Undo accidental change in test/automation/package.json.

    @rehmsen
    rehmsen committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f68fa7e View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Use MutableDisposable and await _updateThread.

    @rehmsen
    rehmsen committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    825680c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into notebook_comment_lifecycle

    @rehmsen
    rehmsen authored Jun 17, 2024
    1 Configuration menu
    Copy the full SHA
    87aad98 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Revert again the unintentional change to test/automation/package.json. 

    I wonder if VSCode or some extension I have keeps updating this? I am not doing it handishly. Anyways, gone again.
    @rehmsen
    rehmsen committed Jun 18, 2024
    1 Configuration menu
    Copy the full SHA
    52f062f View commit details
    Browse the repository at this point in the history