Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs in #214589 fixing #213535. #218357

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Fix two bugs in #214589 fixing #213535. #218357

merged 4 commits into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. Fix two bugs in microsoft#214589. 

    1. We must not `dispose()` the `MutableDisposable` `this._commentThreadWidget` - as that disposes the MutableDisposable itself, and it cannot then later be reassigned to a new value. Instead, we need to assign `value=undefined`, which disposes the previous `value`, but keeps the `MutableDisposable` available to be reused later.
2. `initialize()` is a no-op if `this.currentElement` is already identical to the passed `element`, so we must not do that assignment before calling initialize - instead `initialize()` does the assignment after checking.
    @rehmsen
    rehmsen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8e3cd9e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix_notebook_comment_lifecycle

    @rehmsen
    rehmsen authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8d36423 View commit details
    Browse the repository at this point in the history

  3. Fix blank line.

    @rehmsen
    rehmsen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ab8621e View commit details
    Browse the repository at this point in the history

  4. Register the _commentThreadWidget MutableDisposable so that it gets d… 

    …isposed when CellComments is disposed.
    @rehmsen
    rehmsen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    08554a6 View commit details
    Browse the repository at this point in the history