Remove MultiRowEditorControl Hack and properly redraw tabs on restore #220090
+10
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Jul 5, 2024
src/vs/workbench/browser/parts/editor/multiRowEditorTabsControl.ts
Outdated
Show resolved
Hide resolved
|
I was able to remove the hack. However, I had to also remove the optimization on selection redraw which needs to be revisited. #213160 The optimization should probably be to keep a list of selected tabs which have been drawn, then when they should be drawn again due to |
benibenj
changed the title
bpasero
reviewed
Jul 5, 2024
bpasero
requested changes
Jul 5, 2024
|
Similar to the restore editors problem. When changing the type of tab bar, we should open all editors and not just the active one. |
bpasero
approved these changes
Jul 7, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this pull request
Jul 10, 2024
…microsoft#220090) * update misleading commen * Remove Hack * 💄 * still update title sync * open all editors on tab bar change --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the MultiRowEditorControl class was misleading and has been updated to provide accurate information.
#193690