Revert StableEditorScroll changes #224290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
added
the
candidate
ulugbekna
approved these changes
Jul 30, 2024
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Sep 2, 2024
Revert "Fixes microsoft#216824" This reverts commit f46e922.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #221031 which changed the behavior of the StableEditorScroll and caused unexpected behaviors in the diff editor and in the comments view.
Reopens #216824
Fixes #224275
Fixes #224263
fyi @hediet