Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support commenting cells outside of viewport + range tracking #225187

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Support commenting cells outside of viewport + range tracking #225187

merged 8 commits into from
Aug 9, 2024

Conversation

Yoyokrazy
Copy link
Contributor

Fixes: #223344

@Yoyokrazy Yoyokrazy self-assigned this Aug 8, 2024
@Yoyokrazy
Copy link
Contributor Author

Yoyokrazy commented Aug 8, 2024 •
edited
Loading

todo:

  • need to store editor comment settings on the cell models, insertSpaces and ignoreEmptyLines

@Yoyokrazy Yoyokrazy requested a review from rebornix August 8, 2024 21:49
rebornix
rebornix requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we don't need our own editBuilder/rangeTracking at all.

@Yoyokrazy Yoyokrazy marked this pull request as ready for review August 9, 2024 18:31
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 9, 2024
@microsoft microsoft deleted a comment from rebornix Aug 9, 2024
@Yoyokrazy Yoyokrazy requested a review from rebornix August 9, 2024 20:22
@Yoyokrazy Yoyokrazy merged commit 24080f9 into main Aug 9, 2024
6 checks passed
@Yoyokrazy Yoyokrazy deleted the milively/model-comment-cells branch August 9, 2024 20:53
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

Handling of cells outside of viewport
2 participants
@Yoyokrazy @rebornix