Support actions in notebook diff items #226220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Aug 22, 2024
| // Possible the metadata was edited as part of diff view | ||
| // In diff view we display execution_count as part of metadata, hence when execution count changes in metadata, | ||
| // We need to change that here as well, i.e. give preference to any execution_count value in metadata. | ||
| execution_count: cellMetadata.execution_count ?? cell.executionSummary?.executionOrder ?? null, |
There was a problem hiding this comment.
Bug fix, reverting metadata or changing exec count in metadata doesn't work even in todays diff viewer
DonJayamanne
commented
Aug 22, 2024
src/vs/workbench/contrib/notebook/browser/diff/notebookDiffViewModel.ts
Outdated
Show resolved
Hide resolved
harshitrathore68
approved these changes
Aug 22, 2024
DonJayamanne
force-pushed
the
don/issue224760.3
branch
from
083a140
to
9754f5e
Compare
rebornix
previously approved these changes
Aug 22, 2024
rebornix
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #224760