Move shell integration scripts into common #227244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
previously approved these changes
Aug 30, 2024
|
Heh, ok I can make this work. I'll need to just swap https://github.com/PowerShell/vscode-powershell/blob/efd6fd56a46cc44d51ea7c80644a2baa3eb75559/src/utils.ts#L10-L11 based on VS Code version...are you able to tell me which exact version this will land so I can pre-emptively add that check? (Searching through my code...is a string check against |
|
@andyleejordan it should be the first 1.94 insiders that'll have this, so any >= 1.94 should have it |
alexdima
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225665
cc @andyleejordan