Add event for when tree tokens change #228593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalebers
approved these changes
Sep 16, 2024
hediet
approved these changes
Sep 18, 2024
| @@ -102,7 +105,13 @@ export class TextModelTreeSitter extends Disposable { | |||
| } | |||
|
|
|||
| private async _onDidChangeContent(treeSitterTree: TreeSitterParseResult, changes: IModelContentChange[]) { | |||
| return treeSitterTree.onDidChangeContent(this.model, changes); | |||
| const oldTree = treeSitterTree.tree?.copy(); | |||
| await treeSitterTree.onDidChangeContent(this.model, changes); | |||
There was a problem hiding this comment.
Not sure if that is a problem here, but subsequent onDidChangeContent event calls can make multiple promises to get stuck here.
Then line 110 might cause a race condition, depending on which promise resolves first.
There was a problem hiding this comment.
The actual changes done in onDidChangecontent are queued, so don't think we need to worry about the order in which they are resolved: they will always be sequential.
However, we could end up with this._onDidChangeParseResult firing with the same range multiple times.
There was a problem hiding this comment.
Attempted to address in #228986.
alexr00
added a commit
that referenced
this pull request
Sep 18, 2024
alexr00
added a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #210475