Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moveline autoindent#14390 #23246

Closed
wants to merge 9,859 commits into from
Closed

Moveline autoindent#14390 #23246

wants to merge 9,859 commits into from

Conversation

ice-blaze
Copy link

Main issue #14390
Another Issue in which it could be related #22093.

Questions, is there a way to test performances ?
The algorithm work like this:

  • When moving lines, it will inherit the whitespaces of the next line.
  • In some cases depending on the start or end of the line, if it's one of thoses chars []{}(): it will indent correctly the line

I created some tests, but I need to have some other feedbacks:

  • Does the tests cover all the cases ?
  • Could be possible performence issue ?
  • Anything else that could be bad ?

For the issue #22093, they are talking aboit a different approache, after moving the lines, we use an auto indent functionality. Why not I would say but it seems for now the current autoindent feature isn't working well for selected code.

alexdima and others added 30 commits March 21, 2017 15:11
Fixed typo - fourth instead if forth
Make more descriptive appdata summary field
backups: stop lowercasing file paths (fixes #16591)
@msftclas
Copy link

@ice-blaze,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@ice-blaze, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@ice-blaze ice-blaze closed this Mar 26, 2017
@ice-blaze ice-blaze deleted the moveline-autoindent#14390 branch March 26, 2017 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.