code block pasting in chat #233358
Merged
code block pasting in chat #233358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justschen
commented
Nov 13, 2024
justschen
commented
Nov 13, 2024
justschen
commented
Nov 13, 2024
jrieken
requested changes
Nov 14, 2024
mjbvz
reviewed
Nov 14, 2024
mjbvz
requested changes
Nov 14, 2024
| const fileName = file.split('/').pop() || 'unknown file'; | ||
| const start = ranges.startLineNumber; | ||
| const end = ranges.endLineNumber; | ||
| const resultText = `Copied Selection of Code: \n\n\n From the file: ${fileName} From lines ${start} to ${end} \n \`\`\`${code}\`\`\``; |
There was a problem hiding this comment.
Does this need to be valid markdown? If it does, you can use the createFencedCodeBlock helper with have for copilot as this will handle cases where the code contains triple backticks
mjbvz
reviewed
Nov 18, 2024
jrieken
previously approved these changes
Nov 19, 2024
mjbvz
reviewed
Nov 19, 2024
mjbvz
requested changes
Nov 19, 2024
mjbvz
approved these changes
Nov 19, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. @jrieken