Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quiet Light theme attribute colors #57934

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

miguelsolorio
Copy link
Contributor

Fixes #56791

Updated the attribute color from #AB6526 to #9C5D27 so that it passes the color contrast ratio for the editor background color and on selection:

image

@miguelsolorio miguelsolorio changed the title Update Quiet Light attribute colors Update Quiet Light theme attribute colors Sep 5, 2018
@prashant-andani
Copy link

LGTM

@miguelsolorio miguelsolorio merged commit a3f9f2e into master Sep 7, 2018
@miguelsolorio miguelsolorio deleted the misolori/quiet-light-theme branch September 7, 2018 04:19
@isidorn
Copy link
Contributor

isidorn commented Sep 17, 2018

@misolori lovely. Sorry for the slow reponse, I was on vacation.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color contrast not appropraite for json attributes in QuiteLight theme
3 participants